Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag for disabling new logins #15246

Open
sethmlarson opened this issue Jan 22, 2024 · 1 comment
Open

Add flag for disabling new logins #15246

sethmlarson opened this issue Jan 22, 2024 · 1 comment
Labels
feature request security Security-related issues and pull requests

Comments

@sethmlarson
Copy link
Contributor

sethmlarson commented Jan 22, 2024

What's the problem this feature will solve?

Credential stuffing attacks are becoming more common. It may be useful to have a flag which disables or restricts logins to prevent credential stuffing attacks from having a widespread impact. Having a flag allows us to regroup and determine next steps without being on a clock.

We already do a great job by having a IP address rate limit and requiring 2FA (so hopefully accounts of high value have already added 2FA?) and having metrics monitoring for login failures so we'd hopefully never need to use the flag. This feature came up in a discussion about credential stuffing that affected other services. I think a fine outcome of this issue is to decide we don't need such a flag.

Other thoughts:

  • Maybe can limit logging in to non-2FA accounts instead of all accounts?
  • Mike also suggested alternatives such as requiring solving a captcha to login instead of disabling logins completely.
@sethmlarson sethmlarson added feature request requires triaging maintainers need to do initial inspection of issue labels Jan 22, 2024
@woodruffw
Copy link
Member

In terms of implementation, this would probably another flag under AdminFlagValues:

class AdminFlagValue(enum.Enum):
DISABLE_ORGANIZATIONS = "disable-organizations"
DISALLOW_DELETION = "disallow-deletion"
DISALLOW_NEW_PROJECT_REGISTRATION = "disallow-new-project-registration"
DISALLOW_NEW_UPLOAD = "disallow-new-upload"
DISALLOW_NEW_USER_REGISTRATION = "disallow-new-user-registration"
DISALLOW_OIDC = "disallow-oidc"
DISALLOW_GITHUB_OIDC = "disallow-github-oidc"
DISALLOW_GOOGLE_OIDC = "disallow-google-oidc"
DISALLOW_ACTIVESTATE_OIDC = "disallow-activestate-oidc"
READ_ONLY = "read-only"

@miketheman miketheman added security Security-related issues and pull requests and removed requires triaging maintainers need to do initial inspection of issue labels May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request security Security-related issues and pull requests
Projects
None yet
Development

No branches or pull requests

3 participants