Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consider locking after every install #50

Closed
kennethreitz opened this issue Jan 23, 2017 · 4 comments
Closed

consider locking after every install #50

kennethreitz opened this issue Jan 23, 2017 · 4 comments
Labels
Type: Enhancement 💡 This is a feature or enhancement request. Type: Question ❔ This is a question or a request for support.

Comments

@kennethreitz
Copy link
Contributor

No description provided.

@kennethreitz kennethreitz changed the title consider freezing after every install consider locking after every install Jan 23, 2017
@kennethreitz kennethreitz added Type: Enhancement 💡 This is a feature or enhancement request. Type: Question ❔ This is a question or a request for support. labels Jan 23, 2017
@jpadilla
Copy link
Contributor

+1 on this. npm updates its shrinkwrap.json if installing/saving the package.json and yarn does the same with yarn.lock.

I think it might be a good rule that if we're updating the Pipfile, we also update the Pipfile.lock, instead of having the user do so everytime. I could tackle this.

@kennethreitz
Copy link
Contributor Author

the only downside is that currently locking is a rather expensive (time-wise) operation.

@rmad17
Copy link

rmad17 commented Jan 24, 2017

How about an optional parameter to check for locking after install?

@kennethreitz
Copy link
Contributor Author

@rmad17 done!

@jpadilla jpadilla mentioned this issue Jan 29, 2017
Closed
@KPrasch KPrasch mentioned this issue Jun 26, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Enhancement 💡 This is a feature or enhancement request. Type: Question ❔ This is a question or a request for support.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jpadilla @kennethreitz @rmad17