-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
11.1.8+ broke pipenv lock/install of --dev -e . #1653
Comments
Cannot reproduce — do you have anything else in your Pipfile? |
Yeah, I cannot reproduce this at all. Please run |
Based on your traceback though, even though I can't reproduce, I'm making this change... |
#1653 Signed-off-by: Kenneth Reitz <me@kennethreitz.org>
Could it be related to using a private (devpi) PyPI? That was my original suspicion but I only could trigger it with -e . |
Possibly. I think my patch will fix it, regardless. Will have a release out shortly. |
I have no idea how |
Try this one:
then run https://pypi.fcio.net/simple/ is AFAIK bandersnatch FWIW but it break too for me. P.S. It’s obviously also just pipenv lock that’s broken here. The talking about install was kind of a red herring. |
That worked fine (in master). I think I fixed the bug. |
Going to cut a release. |
Could you double check with last release it breaks for you too? I’m not at my Mac to test. |
sure |
Not reproducing, but this patch should absolutely cover this hard-to-reproduce edge case. |
Released, as v11.3.0. |
Give that a try, and let me know if this is still happening. |
P.S. Resolvers are hard. |
And I just forked an existing one :) |
Oh man I’m afraid you broke something big time. I cannot investigate heavily but when I run update a bunch of dependencies vanished from the lock files. Try install-locking this: [[source]]
url = "https://pypi.fcio.net/simple/"
verify_ssl = true
name = "pypi"
[packages]
"e1839a8" = {path = ".", editable = true}
autobahn = {extras = ["accelerate", "encryption", "asyncio", "serialization"]}
[dev-packages]
[requires]
python_version = "3.6" Latest pipenv: {
"_meta": {
"hash": {
"sha256": "b7165fe60d6b304e5e67f2c63317ed2cb2289e3cbd61778c979a8080f9480d57"
},
"pipfile-spec": 6,
"requires": {
"python_version": "3.6"
},
"sources": [
{
"name": "pypi",
"url": "https://pypi.fcio.net/simple/",
"verify_ssl": true
}
]
},
"default": {
"autobahn": {
"hashes": [
"sha256:13199ac8e75bde47e8c2468386ce95c2489d3c7ef3eb25ef9f53094f8a2a5f0f",
"sha256:fc1d38227bb44a453b54cffa48de8b2e6ce48ddc5e97fb5950b0faa27576f385"
],
"version": "==18.3.1"
},
"e1839a8": {
"editable": true,
"path": "."
}
},
"develop": {}
} With pipenv 11.1.7 I get: {
"_meta": {
"hash": {
"sha256": "0f78f89f80f63027edf66ebd3e6f72f3f0de0d10b3d24fc776145d099eed322f"
},
"pipfile-spec": 6,
"requires": {
"python_version": "3.6"
},
"sources": [
{
"name": "pypi",
"url": "https://pypi.fcio.net/simple/",
"verify_ssl": true
}
]
},
"default": {
"asn1crypto": {
"hashes": [
"sha256:2f1adbb7546ed199e3c90ef23ec95c5cf3585bac7d11fb7eb562a3fe89c64e87",
"sha256:9d5c20441baf0cb60a4ac34cc447c6c189024b6b4c6cd7877034f4965c464e49"
],
"version": "==0.24.0"
},
"attrs": {
"hashes": [
"sha256:1c7960ccfd6a005cd9f7ba884e6316b5e430a3f1a6c37c5f87d8b43f83b54ec9",
"sha256:a17a9573a6f475c99b551c0e0a812707ddda1ec9653bed04c13841404ed6f450"
],
"version": "==17.4.0"
},
"autobahn": {
"hashes": [
"sha256:13199ac8e75bde47e8c2468386ce95c2489d3c7ef3eb25ef9f53094f8a2a5f0f",
"sha256:fc1d38227bb44a453b54cffa48de8b2e6ce48ddc5e97fb5950b0faa27576f385"
],
"version": "==18.3.1"
},
"cbor": {
"hashes": [
"sha256:13225a262ddf5615cbd9fd55a76a0d53069d18b07d2e9f19c39e6acb8609bbb6"
],
"version": "==1.0.0"
},
"cffi": {
"hashes": [
"sha256:151b7eefd035c56b2b2e1eb9963c90c6302dc15fbd8c1c0a83a163ff2c7d7743",
"sha256:1553d1e99f035ace1c0544050622b7bc963374a00c467edafac50ad7bd276aef",
"sha256:1b0493c091a1898f1136e3f4f991a784437fac3673780ff9de3bcf46c80b6b50",
"sha256:2ba8a45822b7aee805ab49abfe7eec16b90587f7f26df20c71dd89e45a97076f",
"sha256:3c85641778460581c42924384f5e68076d724ceac0f267d66c757f7535069c93",
"sha256:3eb6434197633b7748cea30bf0ba9f66727cdce45117a712b29a443943733257",
"sha256:4c91af6e967c2015729d3e69c2e51d92f9898c330d6a851bf8f121236f3defd3",
"sha256:770f3782b31f50b68627e22f91cb182c48c47c02eb405fd689472aa7b7aa16dc",
"sha256:79f9b6f7c46ae1f8ded75f68cf8ad50e5729ed4d590c74840471fc2823457d04",
"sha256:7a33145e04d44ce95bcd71e522b478d282ad0eafaf34fe1ec5bbd73e662f22b6",
"sha256:857959354ae3a6fa3da6651b966d13b0a8bed6bbc87a0de7b38a549db1d2a359",
"sha256:87f37fe5130574ff76c17cab61e7d2538a16f843bb7bca8ebbc4b12de3078596",
"sha256:95d5251e4b5ca00061f9d9f3d6fe537247e145a8524ae9fd30a2f8fbce993b5b",
"sha256:9d1d3e63a4afdc29bd76ce6aa9d58c771cd1599fbba8cf5057e7860b203710dd",
"sha256:a36c5c154f9d42ec176e6e620cb0dd275744aa1d804786a71ac37dc3661a5e95",
"sha256:ae5e35a2c189d397b91034642cb0eab0e346f776ec2eb44a49a459e6615d6e2e",
"sha256:b0f7d4a3df8f06cf49f9f121bead236e328074de6449866515cea4907bbc63d6",
"sha256:b75110fb114fa366b29a027d0c9be3709579602ae111ff61674d28c93606acca",
"sha256:ba5e697569f84b13640c9e193170e89c13c6244c24400fc57e88724ef610cd31",
"sha256:be2a9b390f77fd7676d80bc3cdc4f8edb940d8c198ed2d8c0be1319018c778e1",
"sha256:d5d8555d9bfc3f02385c1c37e9f998e2011f0db4f90e250e5bc0c0a85a813085",
"sha256:e55e22ac0a30023426564b1059b035973ec82186ddddbac867078435801c7801",
"sha256:e90f17980e6ab0f3c2f3730e56d1fe9bcba1891eeea58966e89d352492cc74f4",
"sha256:ecbb7b01409e9b782df5ded849c178a0aa7c906cf8c5a67368047daab282b184",
"sha256:ed01918d545a38998bfa5902c7c00e0fee90e957ce036a4000a88e3fe2264917",
"sha256:edabd457cd23a02965166026fd9bfd196f4324fe6032e866d0f3bd0301cd486f",
"sha256:fdf1c1dc5bafc32bc5d08b054f94d659422b05aba244d6be4ddc1c72d9aa70fb"
],
"version": "==1.11.5"
},
"cryptography": {
"hashes": [
"sha256:0d39a93cf25edeae1f796bbc5960e587f34513a852564f6345ea4491a86c5997",
"sha256:18d0b0fc21f39b35ea469a82584f55eeecec1f65a92d85af712c425bdef627b3",
"sha256:27a208b9600166976182351174948e128818e7fc95cbdba18143f3106a211546",
"sha256:28e4e9a97713aa47b5ef9c5003def2eb58aec89781ef3ef82b1c2916a8b0639b",
"sha256:2cfcee8829c5dec55597826d52c26bc26e7ce39adb4771584459d0636b0b7108",
"sha256:33b564196dcd563e309a0b07444e31611368afe3a3822160c046f5e4c3b5cdd7",
"sha256:41f94194ae78f83fd94ca94fb8ad65f92210a76a2421169ffa5c33c3ec7605f4",
"sha256:4f385ee7d39ee1ed74f1d6b1da03d0734ea82855a7b28a9e6e88c4091bc58664",
"sha256:55555d784cfdf9033e81f044c0df04babed2aa141213765d960d233b0139e353",
"sha256:69285f5615507b6625f89ea1048addd1d9218585fb886eb90bdebb1d2b2d26f5",
"sha256:6cb1224da391fa90f1be524eafb375b62baf8d3df9690b32e8cc475ccfccee5e",
"sha256:6fb22f63e17813f3d1d8e30dd1e249e2c34233ba1d3de977fd31cb5db764c7d0",
"sha256:7a2409f1564c84bcf2563d379c9b6148c5bc6b0ae46e109f6a7b4bebadf551df",
"sha256:8487524a1212223ca6dc7e2c8913024618f7ff29855c98869088e3818d5f6733",
"sha256:9a2945efcff84830c8e237ab037d0269380d75d400a89cc9e5628e52647e21be",
"sha256:9a47a80f65f4feaaf8415a40c339806c7d7d867152ddccc6ca87f707c8b7b565",
"sha256:a3c180d12ffb1d8ee5b33a514a5bcb2a9cc06cc89aa74038015591170c82f55d",
"sha256:a5f2c681fd040ed648513939a1dd2242af19bd5e9e79e53b6dcfa33bdae61217",
"sha256:b984523d28737e373c7c35c8b6db6001537609d47534892de189bebebaa42a47",
"sha256:d18df9cf3f3212df28d445ea82ce702c4d7a35817ef7a38ee38879ffa8f7e857",
"sha256:e4d967371c5b6b2e67855066471d844c5d52d210c36c28d49a8507b96e2c5291",
"sha256:ee245f185fae723133511e2450be08a66c2eebb53ad27c0c19b228029f4748a5",
"sha256:fc2208d95d9ecc8032f5e38330d5ace2e3b0b998e42b08c30c35b2ab3a4a3bc8"
],
"version": "==2.1.4"
},
"e1839a8": {
"editable": true,
"path": "."
},
"idna": {
"hashes": [
"sha256:2c6a5de3089009e3da7c5dde64a141dbc8551d5b7f6cf4ed7c2568d0cc520a8f",
"sha256:8c7309c718f94b3a625cb648ace320157ad16ff131ae0af362c9f21b80ef6ec4"
],
"version": "==2.6"
},
"py-ubjson": {
"hashes": [
"sha256:81784e64936c12e218afc49ff4fb90702f298ac16848971d9570c87595860762"
],
"version": "==0.11.0"
},
"pyasn1": {
"hashes": [
"sha256:d258b0a71994f7770599835249cece1caef3c70def868c4915e6e5ca49b67d15",
"sha256:d5cd6ed995dba16fad0c521cfe31cd2d68400b53fcc2bce93326829be73ab6d1"
],
"version": "==0.4.2"
},
"pyasn1-modules": {
"hashes": [
"sha256:47fb6757ab78fe966e7c58b2030b546854f78416d653163f0ce9290cf2278e8b",
"sha256:af00ea8f2022b6287dc375b2c70f31ab5af83989fc6fe9eacd4976ce26cd7ccc"
],
"version": "==0.2.1"
},
"pycparser": {
"hashes": [
"sha256:99a8ca03e29851d96616ad0404b4aad7d9ee16f25c9f9708a11faf2810f7b226"
],
"version": "==2.18"
},
"pynacl": {
"hashes": [
"sha256:04e30e5bdeeb2d5b34107f28cd2f5bbfdc6c616f3be88fc6f53582ff1669eeca",
"sha256:0bfa0d94d2be6874e40f896e0a67e290749151e7de767c5aefbad1121cad7512",
"sha256:11aa4e141b2456ce5cecc19c130e970793fa3a2c2e6fbb8ad65b28f35aa9e6b6",
"sha256:13bdc1fe084ff9ac7653ae5a924cae03bf4bb07c6667c9eb5b6eb3c570220776",
"sha256:14339dc233e7a9dda80a3800e64e7ff89d0878ba23360eea24f1af1b13772cac",
"sha256:1d33e775fab3f383167afb20b9927aaf4961b953d76eeb271a5703a6d756b65b",
"sha256:2a42b2399d0428619e58dac7734838102d35f6dcdee149e0088823629bf99fbb",
"sha256:2dce05ac8b3c37b9e2f65eab56c544885607394753e9613fd159d5e2045c2d98",
"sha256:6453b0dae593163ffc6db6f9c9c1597d35c650598e2c39c0590d1757207a1ac2",
"sha256:73a5a96fb5fbf2215beee2353a128d382dbca83f5341f0d3c750877a236569ef",
"sha256:8abb4ef79161a5f58848b30ab6fb98d8c466da21fdd65558ce1d7afc02c70b5f",
"sha256:8ac1167195b32a8755de06efd5b2d2fe76fc864517dab66aaf65662cc59e1988",
"sha256:8f505f42f659012794414fa57c498404e64db78f1d98dfd40e318c569f3c783b",
"sha256:be71cd5fce04061e1f3d39597f93619c80cdd3558a6c9ba99a546f144a8d8101",
"sha256:cf6877124ae6a0698404e169b3ba534542cfbc43f939d46b927d956daf0a373a",
"sha256:d0eb5b2795b7ee2cbcfcadacbe95a13afbda048a262bd369da9904fecb568975",
"sha256:d795f506bcc9463efb5ebb0f65ed77921dcc9e0a50499dedd89f208445de9ecb",
"sha256:d8aaf7e5d6b0e0ef7d6dbf7abeb75085713d0100b4eb1a4e4e857de76d77ac45",
"sha256:e0d38fa0a75f65f556fb912f2c6790d1fa29b7dd27a1d9cc5591b281321eaaa9",
"sha256:eb2acabbd487a46b38540a819ef67e477a674481f84a82a7ba2234b9ba46f752",
"sha256:eeee629828d0eb4f6d98ac41e9a3a6461d114d1d0aa111a8931c049359298da0",
"sha256:f5ce9e26d25eb0b2d96f3ef0ad70e1d3ae89b5d60255c462252a3e456a48c053",
"sha256:fabf73d5d0286f9e078774f3435601d2735c94ce9e514ac4fb945701edead7e4"
],
"version": "==1.2.1"
},
"pyopenssl": {
"hashes": [
"sha256:07a2de1a54de07448732a81e38a55df7da109b2f47f599f8bb35b0cbec69d4bd",
"sha256:2c10cfba46a52c0b0950118981d61e72c1e5b1aac451ca1bc77de1a679456773"
],
"version": "==17.5.0"
},
"pyqrcode": {
"hashes": [
"sha256:1b2812775fa6ff5c527977c4cd2ccb07051ca7d0bc0aecf937a43864abe5eff6",
"sha256:fdbf7634733e56b72e27f9bce46e4550b75a3a2c420414035cae9d9d26b234d5"
],
"version": "==1.2.1"
},
"pytrie": {
"hashes": [
"sha256:0c1bd0cb7c301b193da4bcf31bdf68bbdbea88be4bea5f680caecc56d9b74020"
],
"version": "==0.3"
},
"service-identity": {
"hashes": [
"sha256:0e76f3c042cc0f5c7e6da002cf646f59dc4023962d1d1166343ce53bdad39e17",
"sha256:4001fbb3da19e0df22c47a06d29681a398473af4aa9d745eca525b3b2c2302ab"
],
"version": "==17.0.0"
},
"six": {
"hashes": [
"sha256:70e8a77beed4562e7f14fe23a786b54f6296e34344c23bc42f07b15018ff98e9",
"sha256:832dc0e10feb1aa2c68dcc57dbb658f1c7e65b9b61af69048abc87a2db00a0eb"
],
"version": "==1.11.0"
},
"sortedcontainers": {
"hashes": [
"sha256:844daced0f20d75c02ce53f373d048ea2e401ad8a7b3a4c43b2aa544b569efb3",
"sha256:fb9e22cd6ee4b459f0d7b9b4189b19631031c72ac05715563139162014c13672"
],
"version": "==1.5.9"
},
"txaio": {
"hashes": [
"sha256:31fcc61962fef04841968a516abc20891a9387c91be4db75c0a0a092b191006e",
"sha256:dfc3a7d04b4b484ae5ff241affab5bb01306b1e950dd6f54fd036cfca94345d0"
],
"version": "==2.9.0"
},
"u-msgpack-python": {
"hashes": [
"sha256:2f31fc1b6dd8632c230ea7012470e40f77119f20999274dda6f1afa9c305e590",
"sha256:4b509782648fc563f85cef03887389c7fba3b077a47920a13d3d4ea78652ffd2"
],
"version": "==2.4.1"
},
"wsaccel": {
"hashes": [
"sha256:425706acf0724d2f6bfa391ec37b4ef121d3432c956029de3cea4e101c218e0c"
],
"version": "==0.6.2"
}
},
"develop": {}
} Seems like dependency resolution is fucked real good. :| |
deps of editable installs only get installed when the deps are installed. |
so,
|
The editable doesn’t matter now. I get the same behavior if I remove it. |
I'm getting the full graph on this side. |
Try |
|
Run |
In a fresh directory:
Please not how much it installs and how little (1) it locks. I ran |
I ran your exact steps, and I'm getting a full graph. Please run |
Pipenv version: Pipenv location: Python location: Other Python installations in
PEP 508 Information:
System environment variables:
Pipenv–specific environment variables:
Debug–specific environment variables:
Contents of [[source]]
url = "https://pypi.python.org/simple"
verify_ssl = true
name = "pypi"
[packages]
autobahn = {extras = ["encryption", "accelerate", "asyncio", "serialization"]}
[dev-packages]
[requires]
python_version = "3.6"
Contents of {
"_meta": {
"hash": {
"sha256": "b971c00a9857b53b850aa1369493405ede94d0e9039a7bb771178c30e84bb2c2"
},
"pipfile-spec": 6,
"requires": {
"python_version": "3.6"
},
"sources": [
{
"name": "pypi",
"url": "https://pypi.python.org/simple",
"verify_ssl": true
}
]
},
"default": {
"autobahn": {
"hashes": [
"sha256:13199ac8e75bde47e8c2468386ce95c2489d3c7ef3eb25ef9f53094f8a2a5f0f",
"sha256:fc1d38227bb44a453b54cffa48de8b2e6ce48ddc5e97fb5950b0faa27576f385"
],
"version": "==18.3.1"
}
},
"develop": {}
}
|
Fun fact:
It seems like it’s literally just the dumping of the lock that’s broken. |
I love how you use your $200 font literally everywhere. |
I got it for free, for the record :) |
Yeah, rub it in. :P |
okay, fixed it! |
Commit??? |
i was doing something dumb |
tests running now, assuming successful pass, will be released momentarily. |
v11.3.2 releaed. Please test @hynek :) |
Seems like you missed some import? |
also:
|
Presumably that is also import related. It seems like the prescribed path modifications are not happening at runtime. |
Likely because we need to set |
yes working on it |
(Or unset it—do you have it set?) |
Lol. What changed about it though? |
making all of pip relative imports |
just patching sys.path again |
i need to take a break — @techalchemy feel free to dig into this. |
k got 11.3.3 out — think it fixes this for good |
will take a deeper look in the morning though, this is the "putting out the fire" release |
Something is still broken. I could narrow it down to installing Verbose output is more helpful:
It seems like it catches itself in an infinite loop flip-flopping the conditional marker. I wonder if that’s related to the bug I keep complaining about but that I wasn’t able to reproduce where pipenv will randomly flip-flop markers on a lock. |
Whoa wtf. @hynek can you |
i think that's for another issue :) |
JFTR, I cannot reproduce it anymore either which makes me 99.9% confident it’s the same bug that haunts me by occasionally stripping markers from the lock files. |
Keep us in the loop! |
Sorry I don’t have the time for the full template dance, but I woke up to a broken pipenv update and could pinpoint it to:
pipenv install --dev -e .
pipenv lock
if the Pipfile contains -e .This is what I get with latest pipenv on lock:
This is what I get with latest pipenv on
pipenv install --dev -e .
:The text was updated successfully, but these errors were encountered: