Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pip doesn't raise on package conflict in extras_require #12607

Open
1 task done
slanton-a opened this issue Apr 2, 2024 · 1 comment
Open
1 task done

Pip doesn't raise on package conflict in extras_require #12607

slanton-a opened this issue Apr 2, 2024 · 1 comment
Labels
C: check Checking dependency graph for consistency type: bug A confirmed bug or unintended behavior

Comments

@slanton-a
Copy link

Description

I have a service that is installing some internal and external packages. In the internal package I have a few extras_require and in the service I have a package that is in conflict with extras_require.
I expect to see this conflict when running pip check

Expected behavior

pip check will display a conflict on the package tenacity. It does show it as conflict if I move it from extras_require to install_requires

pip version

24.0

Python version

3.10

OS

Ubuntu 20.04.6 LTS

How to Reproduce

  1. Have an internal package, called: pack_a with the following info in setup.py
b_dependencies = [
    'pyarrow>=6.0.0, <=12'
]

c_dependencies = [
    'tenacity>=8.2.3'
]

setup_config = {
    "name": 'pack_a',
    "version": '0.0.1',
    "python_requires": '>=3.7',
    "packages": setuptools.find_packages(),
    "include_package_data": True,
    "extras_require": {
        "b": b_dependencies,
        "c": c_dependencies
    },
}
  1. Have a service requirements (tenacity==8.0.1) in requirements.txt file
  2. In the same service, list Internal packages in requirements-internal.txt as install from git with pack_a[b,c] @ git+https://github.com/*****/pack_a.git@0.0.1
  3. Install all packages with pip install -r requirements.txt -r requirements-internal.txt --no-deps
  4. run pip check
  5. See no conflicts on tenacity package

Output

No broken requirements found.

Code of Conduct

@slanton-a slanton-a added S: needs triage Issues/PRs that need to be triaged type: bug A confirmed bug or unintended behavior labels Apr 2, 2024
@ichard26 ichard26 added C: check Checking dependency graph for consistency and removed S: needs triage Issues/PRs that need to be triaged labels Apr 26, 2024
@ichard26
Copy link
Member

See also #4086.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: check Checking dependency graph for consistency type: bug A confirmed bug or unintended behavior
Projects
None yet
Development

No branches or pull requests

2 participants