Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unicode SOABI-related changes #29

Open
4 of 5 tasks
njsmith opened this issue Feb 5, 2016 · 6 comments
Open
4 of 5 tasks

Unicode SOABI-related changes #29

njsmith opened this issue Feb 5, 2016 · 6 comments

Comments

@njsmith
Copy link
Member

njsmith commented Feb 5, 2016

Given discussion here and here, it sounds like we can/should drop the UCS4-only requirement from PEP 513 after all.

If that's right, then I guess there are a few things to do:

  • Update PEP text
  • Update pip pull request
  • Update our check-manylinux.py script
  • Update auditwheel to remove the UCS2 check (but possibly it should unconditionally require the use of an SOABI tag, just to nudge people into doing the right thing?)
  • Update the docker image to include both UCS2 and UCS4 builds for python 2.6 / 2.7. (Also, make sure that it includes a recent-enough wheel package.)

For the docker images, I propose the following layout:

/opt/2.7.11-ucs2
/opt/2.7.11-ucs4
/opt/2.7-ucs2 -> 2.7.11-ucs2
/opt/2.7-ucs4 -> 2.7.11-ucs4
/opt/2.7 -> 2.7-ucs4
@rmcgibbo
Copy link
Member

rmcgibbo commented Feb 5, 2016

On a slightly separate but related note, I wonder if we should rearrange the Pythons layout in a way such that a build script like

for $py in /opt/or/some/other/path/*/bin/python; do
   echo $py
   ...
done

would work nicely and only produce 1 wheel for each unique Python.

@njsmith
Copy link
Member Author

njsmith commented Feb 5, 2016

...yeah, that would be nice, wouldn't it :-)

Option 1: just install into /opt/3.3, /opt/3.4, etc., and skip the whole symlink thing entirely.

Option 2: put symlinks in /python/3.2, /python/3.3, etc.

Option 3: ...?

@rmcgibbo
Copy link
Member

rmcgibbo commented Feb 6, 2016

On distutils-sig, it looks like Nick"s suggestion was to change the PEP text, but leave the docker images as-is.

And we also might need to change the pip PR too?

@njsmith
Copy link
Member Author

njsmith commented Feb 6, 2016

On distutils-sig, it looks like Nick"s suggestion was to change the PEP text, but leave the docker images as-is.

Yeah... I don't have a strong opinion either way. On the one hand, UCS-2 builds are indeed broken, and probably rare (though this isn't really clear). On the other hand, it's kinda up to individual projects whether they decide to provide UCS-2 wheels, and if they want to use the docker image to do so then it's no skin off my nose. Projects that don't want to provide such builds can always skip that regardless.

And we also might need to change the pip PR too?

Good point, edited the checklist above to reflect this.

@njsmith
Copy link
Member Author

njsmith commented Feb 8, 2016

changes to PEP and check-manylinux1.py are in #31

@njsmith
Copy link
Member Author

njsmith commented Mar 24, 2016

Now that #35 is merged, it looks like all that's left here is fixing auditwheel (pypa/auditwheel#16)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants