Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TODO] Update the 2FA nudge error message to use present tense #233

Closed
webknjaz opened this issue Apr 26, 2024 · 0 comments · Fixed by #234
Closed

[TODO] Update the 2FA nudge error message to use present tense #233

webknjaz opened this issue Apr 26, 2024 · 0 comments · Fixed by #234
Assignees
@woodruffw
Labels
enhancement New feature or request good first issue Good for newcomers Hacktoberfest 🎃🐱‍💻 DO's annual PR encouragement help wanted Extra attention is needed

Comments

@webknjaz
Copy link
Member

#190 introduced the initial announcement back in 2023. The promised thing is now implemented and enforced so we have to adapt the text to reflect that.
@webknjaz webknjaz added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers Hacktoberfest 🎃🐱‍💻 DO's annual PR encouragement labels Apr 26, 2024
@webknjaz webknjaz mentioned this issue Apr 26, 2024
Merged
@woodruffw woodruffw mentioned this issue Apr 26, 2024
Merged
webknjaz pushed a commit that referenced this issue May 16, 2024
@woodruffw
Eliminate future tense in the password nudge in twine-upload
771d60f 
Additionally, this turns the corresponding code branch into a hard error in case of the regular PyPI.

Signed-off-by: William Woodruff <william@trailofbits.com>

PR #234
Fixes #233
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@woodruffw woodruffw

Labels
enhancement New feature or request good first issue Good for newcomers Hacktoberfest 🎃🐱‍💻 DO's annual PR encouragement help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

twine-upload: fix tense on password nudge trail-of-forks/gh-action-pypi-publish
2 participants
@webknjaz @woodruffw