Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make solve() able to return newton stages #2185

Open
niklasreich opened this issue Sep 21, 2023 · 1 comment
Open

Make solve() able to return newton stages #2185

niklasreich opened this issue Sep 21, 2023 · 1 comment

Comments

@niklasreich
Copy link
Contributor

Currently it is not possible for the solve() command to return the stages of the Newton scheme. This information is needed for the EIM in nonlinear problems, so for now one has to use the newton() command directly. It would be nice to be able to make the solve() command return the Newton stages as well.

@sdrave
Copy link
Member

sdrave commented Sep 25, 2023

This is a bit more difficult than I initially thought: While returning the Newton stages via the compute output dict is no problem, StationaryModel._compute_solution calls operator.apply_inverse, which then dispatches into newton. Thus, to get hold of the stages, we would need to extend the apply_inverse interface to also let it return additional data. I'm not sure at this point if we want to go this way.

@sdrave sdrave self-assigned this Jan 24, 2024
@sdrave sdrave removed their assignment Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants