Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructuring model and reductor modules #2119

Open
pmli opened this issue Jul 21, 2023 · 0 comments
Open

Restructuring model and reductor modules #2119

pmli opened this issue Jul 21, 2023 · 0 comments

Comments

@pmli
Copy link
Member

pmli commented Jul 21, 2023

src/pymor/models/iosys.py is quite long (currently, it has 3165 lines). It might be good to break it into multiple modules, e.g., lti, so, ph, delay, bilinear under pymor.models (or under pymor.models.iosys).

Related to that, it might be good to separate reductors by the type of model. There is already a pymor.reductors.ph module, so there could be similar ones for lti and so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant