Add option to specify frequency units

[pmli]

Right now, all of the methods of TransferFunction that accept w assume that it is given in rad/s. To unify continuous and discrete-time systems, it would be good to also accept Hz as a unit, since it is independent of the sampling time. The approach could be to add an additional keyword argument, e.g., w_unit, which specifies the unit ('rad/s' or 'Hz').

[ChinmayNadgouda]

Hello,

I am a Master's student in Computer Science from the University of Stuttgart, Germany, and currently am attending the course, Simulation Software Engineering (SSE). https://simulation-software-engineering.github.io/homepage/

For this course, we students were asked to select an open-source simulation framework, like pyMOR and make a small contribution to get acquainted with such open-source software development tool and their practices.

For this, I am interested in pyMOR and am now looking for something to work on. There are no clear expectations as to what this contribution should be. It can be one of the following, a new feature, a tutorial, some documentation or a bug fix.

I am quite new to this field of simulation softwares but eager to learn and would really like to contribute something useful, so is it possible if I work on this "good first issue"?

If yes,
I would like your input and guidance on how to get get started / acquainted with pyMOR and understand it better, so that I can give a meaningful contribution.

If no,
Can you point me to something else that I can contribute to in pyMOR?

Thanks 😄

[pmli]

Hi @ChinmayNadgouda, it's good to hear you are interested to contribute to pyMOR. I don't think anyone else is working on this issue, so you can go ahead. Also, I think this issue should be simple enough.

Try following the developer documentation to set up your development environment. Then you just need to focus on the methods of TransferFunction that accept w (freq_resp, bode, bode_plot, mag_plot). It would also be good to add a test in src/pymortests which checks that, e.g., freq_resp does the right thing.

Feel free to ask if you'll have any questions.

[SEPI-BHR]

Hi, I am newby in contribution to open source projects. As I am intested in this issue, I wanted to know, is there any chance to work on this one?

I briefely checked the issue, but i have some questions . I would really appreciate if I can ask some questions.

[pmli]

Hi @sepid-ai, as there is nobody assigned to this issue and there is no linked pull request, you can work on it.

Of course, feel free to ask questions.