Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iPad Pro basic compatibility #33

Closed
9 tasks done
exsilium opened this issue Aug 7, 2017 · 8 comments
Closed
9 tasks done

iPad Pro basic compatibility #33

exsilium opened this issue Aug 7, 2017 · 8 comments
Assignees
@exsilium
Labels
enhancement
Projects
Release 2.2.x

Comments

@exsilium
Copy link
Collaborator

exsilium commented Aug 7, 2017 •
edited

Ace has greatly improved the compatibility with iPad Pro devices with external keyboard:

Both of these additions are included in the v1.2.8 of Ace. It's, time to see if compatibility can be improved for cloud9 to make it usable with iPad.

Known issues:

  • file browser is not scrollable
  • opening a file with double-click
  • screen size is too big (can we scale back a notch?)
  • hardware keyboard does not work, due to not using default keyboard handler of ace
  • disable overscroll
  • investigate momentum scrolling for editor and tree view
  • full screen mode aka app-capable
  • terminal window does not accept space character 😕
  • arrows don't work in terminal
@exsilium exsilium self-assigned this Aug 7, 2017
@exsilium exsilium changed the title iPad basic compatibility iPad Pro basic compatibility Aug 7, 2017
@exsilium
Copy link
Collaborator Author

Touch device scrolling in file-manager tree is disabled by the hidden overflow:

https://github.com/exsilium/cloud9/blob/master/plugins-client/ext.main/style/skins.xml#L11918

Dynamically setting this to auto allows scrolling in iPad

exsilium added a commit that referenced this issue Sep 18, 2017
@exsilium
Define viewport for the c9 application
0b32bfd 
- contributes to #33
@exsilium
Copy link
Collaborator Author

exsilium commented Oct 4, 2017

Event triggered from hw keyboard don't carry the normal javascript keypress event data. Thus the fix: cb0edef

@exsilium exsilium added this to In Progress in Release 2.2.x Oct 4, 2017
exsilium added a commit that referenced this issue Oct 9, 2017
@exsilium
iPad improvements
371202b 
- scrollable tree
- arrow keys on editor
- contributes to #33
@exsilium
Copy link
Collaborator Author

exsilium commented Oct 9, 2017

Basic tree interaction needs to be delivered in exsilium/apf#2

exsilium added a commit that referenced this issue Oct 10, 2017
@exsilium
iPad improvements
c229edc 
- scrollable tree
- arrow keys on editor
- contributes to #33
@exsilium
Copy link
Collaborator Author

exsilium commented Oct 12, 2017 •
edited

Some annoyances from iOS 11 default settings that need changing manually:

  • Settings -> General -> Keyboard -> Auto-Correction -> Off
  • Settings -> General -> Keyboard -> Smart Punctuation -> Off (interferes with coding by changing "")
  • Settings -> General -> Keyboard -> Shortcuts -> Off (interferes by displaying bottom bar that hides the console prompt)

exsilium added a commit that referenced this issue Oct 12, 2017
@exsilium
Ipad specific improvements
fbf7f3a 
- Contributes to #33
- Momentum scrolling for the tree view only
- Mainly gets rid of the bouncy effect of iOS overscroll
- App capable meta tags set, disallow scaling
@exsilium
Copy link
Collaborator Author

exsilium commented Oct 12, 2017 •
edited

Momentum scrolling is not currently possible/feasible on the editor component because Ace directly reacts against the ontouchmove event.

exsilium added a commit that referenced this issue Oct 13, 2017
@exsilium
Handle space input on iOS keyboard
c8d47b0 
- contributes to #33
@exsilium
Copy link
Collaborator Author

exsilium commented Oct 15, 2017 •
edited

iPad arrows don't work within terminal:

web inspector pipboy-pro safari toi link -

Pull request submitted to xtermjs/xterm.js#1064 / xtermjs/xterm.js#1065
If not accepted, can be solved within the tty.js implementation.

@exsilium exsilium mentioned this issue Oct 16, 2017
Closed
@exsilium
Copy link
Collaborator Author

Arrows fix was submitted and merged with xtermjs/xterm.js#1065 , and finally brought into c9 with 9940929 - Needs testing if it actually works. 🤞

exsilium added a commit that referenced this issue Feb 22, 2018
@exsilium
iPad hw arrows in terminal with xterm.js v3
84416fc 
- On iOS platform we need to keep the focus off from the textarea to be able to detect arrow keys.
- Adding screenshot from iPad
- Contributes to #33
@exsilium exsilium moved this from In Progress to Done in Release 2.2.x Feb 22, 2018
@exsilium
Copy link
Collaborator Author

Delivered in v2.2.0

ljxu1 pushed a commit to ljxu1/cloud9 that referenced this issue May 25, 2019
@exsilium @ljxu1
Define viewport for the c9 application
7bbebfb 
- contributes to pylonide#33
ljxu1 pushed a commit to ljxu1/cloud9 that referenced this issue May 25, 2019
@exsilium @ljxu1
iPad improvements
84639c6 
- scrollable tree
- arrow keys on editor
- contributes to pylonide#33
ljxu1 pushed a commit to ljxu1/cloud9 that referenced this issue May 25, 2019
@exsilium @ljxu1
Ipad specific improvements
975789a 
- Contributes to pylonide#33
- Momentum scrolling for the tree view only
- Mainly gets rid of the bouncy effect of iOS overscroll
- App capable meta tags set, disallow scaling
ljxu1 pushed a commit to ljxu1/cloud9 that referenced this issue May 25, 2019
@exsilium @ljxu1
Handle space input on iOS keyboard
3f3900a 
- contributes to pylonide#33
ljxu1 pushed a commit to ljxu1/cloud9 that referenced this issue May 25, 2019
@exsilium @ljxu1
iPad hw arrows in terminal with xterm.js v3
15a29cc 
- On iOS platform we need to keep the focus off from the textarea to be able to detect arrow keys.
- Adding screenshot from iPad
- Contributes to pylonide#33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@exsilium exsilium

Labels
enhancement
Projects
No open projects
Release 2.2.x
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@exsilium