Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reload Pipeline Results From Directory #1192

Open
2 tasks done
mberr opened this issue Jan 9, 2023 · 2 comments
Open
2 tasks done

Reload Pipeline Results From Directory #1192

mberr opened this issue Jan 9, 2023 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@mberr
Copy link
Member

mberr commented Jan 9, 2023

Problem Statement

Reloading the pykeen.pipeline.PipelineResult object from a directory seems to be frequently desired, cf., e.g.,

Describe the solution you'd like

Add a classmethod, e.g., load_from_directory to pykeen.pipeline.PipelineResult which allows to restore the object from the information stored in the directory.

Describe alternatives you've considered

An alternative could be to improve the documentation on how to load the relevant parts into, e.g., pandas Dataframes.

Additional information

Issue Template Checks

  • This is not a bug report (use a different issue template if it is)
  • This is not a question (use the discussions forum instead)
@mberr mberr added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Jan 9, 2023
@nicolafan
Copy link
Contributor

nicolafan commented Jan 10, 2023

Hello! I was looking into this, and I already have an idea about how to recover the PipelineResult from the files saved to the directory.

How should we treat the following attributes, whose values are not saved to the results directory?

  • random_seed
  • training_loop
  • configuration
  • version
  • git_hash

Everything else can be recovered (I've just a doubt about how to recover the stopper, while I've already seen how to do that for the other attributes). Thank you for your help!

@mberr
Copy link
Member Author

mberr commented Jan 10, 2023

Can we make them optional (i.e., allow providing None for those in case they are not present)? This would allow to load results which have been saved before the current change.

For future save_to_directory calls, we could store them, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants