Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Type Hints to operations, facts & connectors #1074

Open
stone-w4tch3r opened this issue Mar 13, 2024 · 1 comment
Open

Add Type Hints to operations, facts & connectors #1074

stone-w4tch3r opened this issue Mar 13, 2024 · 1 comment
Labels
Connectors Connector issues - builtin integrations with other tools. Facts Issues with facts. Operations Issues with operations.

Comments

@stone-w4tch3r
Copy link
Contributor

What about adding type hints to API? For example, operations will benefit greatly.

for example, apt:

@operation
def packages(
    packages: list[str] = None,
    present=True,
    latest=False,
    update=False,
    cache_time: int = None,
    upgrade=False,
    force=False,
    no_recommends=False,
    allow_downgrades=False,
    extra_install_args: list[str] = None,
    extra_uninstall_args: list[str] = None,
):
    pass
@Fizzadar
Copy link
Member

Absolutely! Now that the core api is (mostly) typed it’s time to start working through operations. Nice thing is each can be done in isolation, welcoming PRs :)

@Fizzadar Fizzadar changed the title Add Type Hints Add Type Hints to operations, facts & connectors Mar 13, 2024
@Fizzadar Fizzadar added Operations Issues with operations. Facts Issues with facts. Connectors Connector issues - builtin integrations with other tools. labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Connectors Connector issues - builtin integrations with other tools. Facts Issues with facts. Operations Issues with operations.
Projects
None yet
Development

No branches or pull requests

2 participants