Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial plans for pyhf-validation #1

Open
3 tasks
matthewfeickert opened this issue Mar 4, 2020 · 6 comments
Open
3 tasks

Initial plans for pyhf-validation #1

matthewfeickert opened this issue Mar 4, 2020 · 6 comments
Assignees

Comments

@matthewfeickert
Copy link
Member

matthewfeickert commented Mar 4, 2020

Transferring some information and ideas from a developer chat with @kratsg:

  • Support CLI that will allow for
pyhf-validation spec.json

that will run pyhf cls over spec.json and additionally runs json2xml+hist2workspace+run_single.py on the resulting ROOT workspace from the HistFactory side.

  • Provide signatures of
delta, pyhf_out, hifa_out = pyhf-validation.run_validation("spec.json")
  • Support ROOT and PyROOT in automated testing
    • Maybe treat it as a soft dependency (try import ROOT; except foo)
@matthewfeickert matthewfeickert self-assigned this Mar 4, 2020
@matthewfeickert
Copy link
Member Author

@danikam has already done a lot of really nice work (c.f. SUSY_1Lbb_xchecks), so it will be important to take what parts of code she already has and port them over when possible.

@danikam
Copy link
Contributor

danikam commented Mar 4, 2020

@danikam has already done a lot of really nice work (c.f. SUSY_1Lbb_xchecks), so it will be important to take what parts of code she already has and port them over when possible.
^^with much help from @lukasheinrich + @kratsg :)

@danikam
Copy link
Contributor

danikam commented Mar 4, 2020

I can work on converting the 1Lbb checks to standalone python functions (assuming ROOT and pyhf dependencies present). Should these go into src/hfval?

@kratsg
Copy link

kratsg commented Mar 4, 2020

I was thinking perhaps you can put them in top-level scripts/ and then slowly migrate into src/hfval ?

@danikam
Copy link
Contributor

danikam commented Mar 4, 2020

Ok, will do!

@matthewfeickert
Copy link
Member Author

Yeah if you can make a PR for the scripts/ then we can do the migration together into src/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants