Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly attribute code taken from wandb #20

Open
matthewfeickert opened this issue Jul 10, 2020 · 0 comments
Open

Properly attribute code taken from wandb #20

matthewfeickert opened this issue Jul 10, 2020 · 0 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@matthewfeickert
Copy link
Member

As properly pointed out by @rct225 (:bow:), the code that was added from wandb in PR #15 is under the MIT License and to properly attribute that code we should

attribute the original author for the parts [we] incorporated and include a copy of the MIT License terms

I'm not 100% on if we actually need to add the MIT Licence into the LICENSE file as I think that Apache 2.0 meets all the requirements for MIT (@lukasheinrich? @kratsg?), but we definitely need to attribute the code to wandb.

@matthewfeickert matthewfeickert added the documentation Improvements or additions to documentation label Jul 10, 2020
@matthewfeickert matthewfeickert self-assigned this Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

1 participant