Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclear duplicate key character map entries in quartzkey.py #1096

Open
pushfoo opened this issue Apr 27, 2024 · 0 comments
Open

Unclear duplicate key character map entries in quartzkey.py #1096

pushfoo opened this issue Apr 27, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@pushfoo
Copy link
Contributor

pushfoo commented Apr 27, 2024

TL;DR: Repeated entries in dict literals lose info

What?

Only the second value will be persisted in the final dict.

'#': key.HASH,
'#': key.POUND,

'`': key.GRAVE,
'`': key.QUOTELEFT,

These are marked as synonyms as synonyms in key.py so the duplication may be intended as a note for readers:

pyglet/pyglet/window/key.py

Lines 330 to 331 in 9fe927d

HASH = 0x023
POUND = 0x023 # synonym

pyglet/pyglet/window/key.py

Lines 366 to 367 in 9fe927d

GRAVE = 0x060
QUOTELEFT = 0x060

I came across this while looking at pyglet/lib for #1084

@pushfoo pushfoo added the bug Something isn't working label Apr 27, 2024
@pushfoo pushfoo changed the title Unclear duplicate key character map entries lose in quartzkey.py Unclear duplicate key character map entries in quartzkey.py Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant