Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sparse version of nn.dense.dense_mincut_pool #9118

Open
xiaohan2012 opened this issue Mar 28, 2024 · 6 comments
Open

Sparse version of nn.dense.dense_mincut_pool #9118

xiaohan2012 opened this issue Mar 28, 2024 · 6 comments
Labels

Comments

@xiaohan2012
Copy link

xiaohan2012 commented Mar 28, 2024

馃殌 The feature, motivation and pitch

The nn.dense.dense_mincut_pool operator requires the input adjacency matrix to be dense. This requirement does not scale well as the matrix size grows. We may use operations on sparse matrix to address this issue.

Alternatives

Additional context

No response

@xiaohan2012
Copy link
Author

If you see any major flaw in this idea, please let me know. I'd be glad to contribute to this idea.

@xiaohan2012
Copy link
Author

xiaohan2012 commented Mar 28, 2024

Similar issue: #7364

@rusty1s
Copy link
Member

rusty1s commented Mar 28, 2024

We initially designed it this way because mincut_pool needs to operate on dense adjacency matrices anyway in consecutive applications. I am definitely open though to support it for both sparse and dense adjacency matrices.

@xiaohan2012
Copy link
Author

Hi, I'm interested in making a pull request. Meanwhile I cannot push my branch to this project. Maybe I need to be added to this project first?

@rusty1s
Copy link
Member

rusty1s commented Apr 26, 2024

If you want to contribute to PyG, you need to fork this repo, push the changes to your local fork, and then submit a PR to PyG.

@xiaohan2012
Copy link
Author

Thanks for the tips. I made a draft PR #9243 but have some questions. It would be great if someone could take a look at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants