Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: phase plot ticks #559

Merged
merged 8 commits into from Apr 10, 2024
Merged

Enhancement: phase plot ticks #559

merged 8 commits into from Apr 10, 2024

Conversation

sikersten
Copy link
Member

@sikersten sikersten commented Mar 14, 2024

Which issue(s) are closed by this pull request?

Closes #540, #542

Changes proposed in this pull request:

Change phase plots

  • if unwrap='360': set y-range to 0-360 / 0-2 pi
  • elif y-range smaller than pi: set range to +/- pi/2 with major ticks at pi/4, minor ticks at pi/8
  • unwrap=True
    • If y-range is smaller than 20pi: major ticks at multiples of 2 pi, minor ticks at multiples of pi
    • If y-range is larger than 20pi: up to 10 major ticks, add multiples of multiples of 20pi, minor ticks at half of major ticks
  • else (unwrap=False (default) or unwrap='360'): minor y-ticks at multiples of pi/4
  • added missing tests for unwrap='360'
  • added tests with small y-range (impulse signal)
  • updated test plots

Have a look at the change of the baseline figures to get an idea.

@sikersten sikersten added enhancement For suggesting enhancements of current functionality plot labels Mar 14, 2024
@sikersten sikersten self-assigned this Mar 14, 2024
@github-actions github-actions bot added this to In progress in Code Backlog Mar 14, 2024
@ahms5 ahms5 changed the base branch from develop to main March 14, 2024 13:53
@sikersten sikersten changed the base branch from main to develop March 22, 2024 09:59
ahms5
ahms5 previously approved these changes Mar 22, 2024
Copy link
Member

@ahms5 ahms5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after doc is fixed

Code Backlog automation moved this from In progress to Reviewer approved Mar 22, 2024
Code Backlog automation moved this from Reviewer approved to Review in progress Mar 22, 2024
@sikersten sikersten requested a review from ahms5 March 22, 2024 13:11
Code Backlog automation moved this from Review in progress to Reviewer approved Mar 22, 2024
@mberz mberz merged commit 229f157 into develop Apr 10, 2024
10 checks passed
Code Backlog automation moved this from Reviewer approved to Done Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement For suggesting enhancements of current functionality plot v0.7.0
Projects
Development

Successfully merging this pull request may close these issues.

Plot phase minor locator at base 2 fractions
3 participants