Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests are redundant #516

Open
artpelling opened this issue Oct 31, 2023 · 1 comment
Open

Tests are redundant #516

artpelling opened this issue Oct 31, 2023 · 1 comment

Comments

@artpelling
Copy link
Contributor

I think a lot of the tests (at least regarding the _Audio related classes) could be simplified by using mark.parametrize with different input signals. A lot of tests are identical across test_audio_signal.py, test_audio_time_data.py and test_audio_frequency_data.py. I suspect that one can find more of these instances.

@mberz
Copy link
Member

mberz commented Feb 6, 2024

I think a lot of this was implemented before we discovered parametrisation is a thing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants