Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reading far data written with old pyfar version will fail in the future #444

Closed
f-brinkmann opened this issue Feb 22, 2023 · 0 comments
Closed
Labels
enhancement For suggesting enhancements of current functionality io merged

Comments

@f-brinkmann
Copy link
Member

General

  • pyfar version: 0.5.2

Description

After deprecating the old coordinates Class in 0.8.0, new pyfar Version will fail in reading old Coordinate objects. I suggest the following as a trade-off between usability and effort

  • write the pyfar version to each .far file
  • always read the version first
  • everything else should be encapsulated in a try statement
  • if reading the data fails, an error with a hint to the pyfar version that was used to save the data is raised
@f-brinkmann f-brinkmann added enhancement For suggesting enhancements of current functionality io labels Feb 22, 2023
@github-actions github-actions bot added this to To do in Code Backlog Feb 22, 2023
Code Backlog automation moved this from To do to Done Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement For suggesting enhancements of current functionality io merged
Projects
Development

No branches or pull requests

1 participant