Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure pf.dsp.regularized_spectrum_inversion #440

Open
f-brinkmann opened this issue Feb 17, 2023 · 0 comments
Open

Restructure pf.dsp.regularized_spectrum_inversion #440

f-brinkmann opened this issue Feb 17, 2023 · 0 comments
Labels
dsp enhancement For suggesting enhancements of current functionality

Comments

@f-brinkmann
Copy link
Member

General

  • pyfar version: 0.5.2

Description

We discussed that function in its current form is a bit too complicated. It has a special case of a regularization function implement through freq_range, etc. and a general case through regu_final. We decided to refactor the function on the long run:

  • move the regularization function generated by freq_range et al. to a separate function/class
  • always require to pass a regularization function to pf.dsp.regularized_spectrum_inversion
  • regularization function must be passed as FrequencyDataobject
@f-brinkmann f-brinkmann added enhancement For suggesting enhancements of current functionality dsp labels Feb 17, 2023
@github-actions github-actions bot added this to To do in Code Backlog Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dsp enhancement For suggesting enhancements of current functionality
Projects
Development

No branches or pull requests

1 participant