Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to specify pixel data as read-only #746

Closed
darcymason opened this issue Sep 20, 2018 · 1 comment · Fixed by #1998
Closed

How to specify pixel data as read-only #746

darcymason opened this issue Sep 20, 2018 · 1 comment · Fixed by #1998

Comments

@darcymason
Copy link
Member

darcymason commented Sep 20, 2018

From discussion in #717. Being able to specify pixel data as read-only can eliminate the need to copy the array in some cases, which can save memory. For very large images or a large number of images, this could be quite advantageous.

Possibly related to #139 also, because specifying read-only would simplify some issues for memory-mapped files.

We need an option in config, or a flag in Dataset, or (some other solution) for users to be able to specify that pixel data (or perhaps any large data array) should be read-only when converted from its raw value.

@darcymason darcymason added this to the v1.5 milestone Jun 29, 2019
@darcymason darcymason modified the milestones: v2.0, v2.3 May 18, 2020
@darcymason
Copy link
Member Author

Pushing this back a few versions ... I think the need for this was much reduced by fixing the read-only pixel array problem, and I think using Dataset.decompress helps a little by modifing PixelData in place allowing the original memory to be freed up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants