Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize replacement functionality #117

Open
wetzelj opened this issue Mar 6, 2020 · 4 comments
Open

Optimize replacement functionality #117

wetzelj opened this issue Mar 6, 2020 · 4 comments

Comments

@wetzelj
Copy link
Contributor

wetzelj commented Mar 6, 2020

As discussed starting in PR #112 (comment), optimize the processing of recipe actions to more efficiently perform defined actions.

I think we would want to parse an entire recipe first, build up a dependency graph of sorts (that also caches originally values that might be needed) and then do the replacements the most efficient way possible, possibly instead of parsing over every action and checking for every field, we first create an assignment of specific actions to specific fields, and then do a much more informed replacement.

@vsoch
Copy link
Member

vsoch commented Apr 29, 2020

I think now that we have the DicomParser, we could look into discussing this again (but once you have some time @wetzelj, don't worry doesn't need to be soon!)

@vsoch
Copy link
Member

vsoch commented Sep 9, 2020

Is this still something we want to discuss, perhaps in the near to distant future? :)

@wetzelj
Copy link
Contributor Author

wetzelj commented Sep 10, 2020

Yes, but not quite yet. We're a few weeks away from releasing our end-user application into user acceptance testing. At that point, we'll see more testing with a diverse sets of images. I suspect that we'll see some minor bugs with the header deidentification once this starts. I'd like to get further along with this testing before starting on this optimization.

@vsoch
Copy link
Member

vsoch commented Sep 10, 2020

okay sounds good :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants