Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function return types need handling #116

Open
vsoch opened this issue Mar 6, 2020 · 1 comment
Open

Function return types need handling #116

vsoch opened this issue Mar 6, 2020 · 1 comment

Comments

@vsoch
Copy link
Member

vsoch commented Mar 6, 2020

As discussed in #113 (review), currently it's possible to provide a function that returns the wrong return type for a variable. This will trigger an error, and likely it should be better handled. Here are some examples from @wetzelj:

- PatientID is defined as DICOM datatype LO (Long String) - custom function returns an integer
- CTDIvol is defined as DICOM datatype FD (Floating Point Double) - custom function returns string

We'd want to better check / handle this, along with adding tests for it.

@vsoch
Copy link
Member Author

vsoch commented Apr 29, 2020

I think we would still need to add this check (quick glance I don't see it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant