Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impending Numba default argument value change #2

Open
realitychemist opened this issue Nov 3, 2023 · 1 comment
Open

Impending Numba default argument value change #2

realitychemist opened this issue Nov 3, 2023 · 1 comment

Comments

@realitychemist
Copy link

When importing stemtool, numba raises the following warning (multiple times):

NumbaDeprecationWarning: The nopython keyword argument was not supplied to the numba.jit decorator. The implicit default value for this argument is currently False, but it will be changed to True in Numba 0.59.0. See https://numba.readthedocs.io/en/stable/reference/deprecation.html#deprecation-of-object-mode-fall-back-behaviour-when-using-jit for details.

The current Numba version is 0.58.0, and based on their previous release schedule I'd expect 0.59.0 within the next six months or so. My understanding is that this warning means that if there is any code in stemtool which is currently falling back to the python interpreter for function calls not supported supported by Numba, after 0.59.0 they will instead raise an error unless nopython is explicitly set to False.

I'm not sure if this will affect stemtool or not, but as there was no current open issue regarding this change it seemed like a good idea to open one.

@dxm447
Copy link
Collaborator

dxm447 commented Nov 3, 2023

I am slowly removing numba dependencies. numpy is plenty fast on it's own, and parallelization through dask works better in my experience. The next release should be numba free.

I am keeping this open, and will close it once numba is completely gone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants