Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gaussian of coordinates close an edge can extend past the image boundary and cause an error. #64

Open
darianSmalley opened this issue Aug 3, 2022 · 1 comment
Labels
bug Something isn't working enhancement New feature or request

Comments

@darianSmalley
Copy link

Function: create_lattice_mask
File: imgen.py
Issue: XY coordinates close an edge can cause an error if their gaussian extends past the boundary.

Potential Solution:
This can be avoided by including cases for the edges to remove the sections of the mask which extend beyond the image boundary and limit the indices to within the image width and height.

Additionally, the previous values of the mask are added to the new mask to allow smoother transitions between overlapping gaussians.

This sort of a solution can be seen in the image below.

image

@ziatdinovmax ziatdinovmax added bug Something isn't working enhancement New feature or request labels Aug 4, 2022
@ziatdinovmax
Copy link
Collaborator

ziatdinovmax commented Aug 4, 2022

@darianSmalley, thanks for noticing it. I think your solution makes sense - would you like to submit a pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants