Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change DI test logic to use dirhash instead of custom hashing #137

Open
matgrioni opened this issue Jun 21, 2023 · 0 comments
Open

Change DI test logic to use dirhash instead of custom hashing #137

matgrioni opened this issue Jun 21, 2023 · 0 comments
Assignees

Comments

@matgrioni
Copy link
Collaborator

At one point, specific directory hashing logic was created for the pyconll DI tests to ensure that the contents downloaded from the UD resources were actually what were expected against some known good downloaded version of the data. However the code is quite complicated and doesn't necessarily handle edge cases all that well. dirhash is good for it, and should be used instead.

@matgrioni matgrioni self-assigned this Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant