Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring to get rid of Comlink objects #69

Closed
5 of 6 tasks
cchwala opened this issue Oct 12, 2020 · 3 comments
Closed
5 of 6 tasks

Refactoring to get rid of Comlink objects #69

cchwala opened this issue Oct 12, 2020 · 3 comments

Comments

@cchwala
Copy link
Contributor

cchwala commented Oct 12, 2020 •
edited

Things that have to be done to get rid of Comlink objects and use xarray.Dataset as basic container for CML data and metadata:

  • read from cmlh5 example data files to xarray.Datasets
  • refactor tests
  • refactor (and clean up) processing functions
  • refactor interpolator
  • refactor validator #108
  • Update example notebooks
@cchwala
Copy link
Contributor Author

cchwala commented Feb 28, 2021 •
edited

Refactoring of basic function is done in in #70

@cchwala cchwala closed this as completed Feb 28, 2021
@cchwala cchwala reopened this Feb 28, 2021
@cchwala
Copy link
Contributor Author

cchwala commented Jul 28, 2021

#73 merged the refactored processing code into master and #77 provided a working version of the example notebook.

@cchwala
Copy link
Contributor Author

cchwala commented Nov 7, 2022

Closing this since the most important parts have been solved long time ago.

Minor task continues in #108.

@cchwala cchwala closed this as completed Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cchwala