Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator should indicate when time series do not overlap #44

Open
cchwala opened this issue Sep 3, 2018 · 0 comments
Open

Validator should indicate when time series do not overlap #44

cchwala opened this issue Sep 3, 2018 · 0 comments

Comments

@cchwala
Copy link
Contributor

cchwala commented Sep 3, 2018

When get_time_series gets called in a GridValidator and the CML time series does not overlap with the one of the validator object, a cryptic error is thrown.

It would be better to raise an exception here that clearly states that there is no overlap.

This could be done here

t_mask = (self.xr_ds.time > t_start) & (self.xr_ds.time < t_stop)

by checking if t_mask contains only NaNs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant