Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use aiohttp instead of websockets #1891

Open
gbtami opened this issue Mar 19, 2021 · 3 comments
Open

Use aiohttp instead of websockets #1891

gbtami opened this issue Mar 19, 2021 · 3 comments
Labels

Comments

@gbtami
Copy link
Member

gbtami commented Mar 19, 2021

Because websockets has no MSYS2 package installing it in MSYS2 environment needs to install the full dev toolchain.
We should use aiohttp instead to make Windows install from sources simpler.
@ecrucru what do you think?

@gbtami gbtami added the task label Mar 19, 2021
@ecrucru
Copy link
Contributor

ecrucru commented Mar 21, 2021

Hello. It should be feasible to analyze that with a reasonable effort. However, the new code base for the remote games relies on python-chess. If this package has the same issue, I suggest to drop the remote games in Pychess.

@gbtami
Copy link
Member Author

gbtami commented Mar 20, 2023

Hmm. There is websocket usage in remotegames.py atm.

@ecrucru
Copy link
Contributor

ecrucru commented Apr 14, 2023

The current files are definitely obsolete. Instead, you may use this new adapted copy:
remotegame.py.txt

All the PyChess functions are replaced by chess.
websockets is replaced by aiohttp.
The detailed log and tests are removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants