Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print value of unknown constant #1047

Closed
EmilyBourne opened this issue Nov 25, 2021 · 0 comments · Fixed by #1120
Closed

Print value of unknown constant #1047

EmilyBourne opened this issue Nov 25, 2021 · 0 comments · Fixed by #1120

Comments

@EmilyBourne
Copy link
Member

Describe the bug
Currently if a constant is not recognised a NotImplementedError is raised here when we try to print the Constant. This seems unnecessary, instead we could simply print the underlying value stored in the Constant

@bauom bauom self-assigned this Sep 21, 2022
EmilyBourne added a commit that referenced this issue May 14, 2024
Print unknown constants using their values. This fixes #1047 but may be
reverted in #1811 to prefer declaring constants with names. However this
PR also adds support for `NaN` in C and an associated test. It also
removes the duplicate `_print_Constant` function.

---------

Co-authored-by: EmilyBourne <louise.bourne@gmail.com>
EmilyBourne added a commit to pyccel/pyccel-cuda that referenced this issue May 14, 2024
Print unknown constants using their values. This fixes pyccel#1047 but may be
reverted in pyccel#1811 to prefer declaring constants with names. However this
PR also adds support for `NaN` in C and an associated test. It also
removes the duplicate `_print_Constant` function.

---------

Co-authored-by: EmilyBourne <louise.bourne@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants