Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Command line property flag to override name is ignored #653

Open
espguitarist33 opened this issue Feb 5, 2020 · 2 comments · May be fixed by #654
Open

Command line property flag to override name is ignored #653

espguitarist33 opened this issue Feb 5, 2020 · 2 comments · May be fixed by #654

Comments

@espguitarist33
Copy link

espguitarist33 commented Feb 5, 2020 •
edited

When passing -P name="newName" through the command line, the hidden property gets updated, but the Project() doesn't calculate the name when needed, so the overridden name (we need branch-specific named pre-builds) is ignored and the original project name gets built.

This tripped me up (actually years ago but had a work around before) as it is listed in the documentation
espguitarist33 pushed a commit to espguitarist33/pybuilder that referenced this issue Feb 5, 2020
https://github.com/pybuilder/pybuilder/issues/653
bedffe4 
Created test to override name attribute in the project
@espguitarist33 espguitarist33 linked a pull request Feb 5, 2020 that will close this issue
Open
@arcivanov
Copy link
Member

I'm travelling and will review this later but to me overriding project name is bizarre and potentially undesirable.

The project name should not be confused with the distribution name, if that's what you're going for. What's your use case?

@espguitarist33
Copy link
Author

espguitarist33 commented Feb 6, 2020 •
edited

Thanks for taking a look... That makes sense

My use case is that I'd like to be able to do something like pip install HarnOS-feature_branch_name to then be able to import my package with "import HarnOS" to install auto-generated test versions of my package prior to merging and utilizing the standard Python snapshots.

We are tracking the branching/testing structure used for the products we test at our company, which requires us to have some level of branch-based build test run capability.

I'm trying to find where I thought I saw this was possible from the documentation, but maybe I crossed up two things.

Is what I'm hoping to do possible with pybuilder? (I'm open to using versions or other fields, it doesn't necessary need to be the project name)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed inability to override project name from command line espguitarist33/pybuilder
2 participants
@arcivanov @espguitarist33