Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR]: Integrated ctest and other project improvements #5095

Open
LecrisUT opened this issue Apr 8, 2024 · 0 comments
Open

[FR]: Integrated ctest and other project improvements #5095

LecrisUT opened this issue Apr 8, 2024 · 0 comments
Labels
triage New bug, unverified

Comments

@LecrisUT
Copy link

LecrisUT commented Apr 8, 2024

Problem description

When trying to work on #5094, I have encountered a few issues:

  • The project does not use ctest. This makes it quite hard for packagers to find and run tests. In principle it should use ctest --build-and-test to test native CMake projects. For some inspiration, here is a template I have.
  • Building and testing from sdist is not possible, i.e.: python3 -m build + pytest
  • Usage of custom Find<Package>.cmake when there are upstream packaging available with good CMake support: catch, eigen3
  • In general, the CMake project can be improved among a few things: inverting the version detection to be defined in CMake, making the CMakeLists.txt files more readable

I am using the ci.yaml to fill in the gaps about how to the testing, but it would be much appreciated if the project can use standardized tools.

@LecrisUT LecrisUT added the triage New bug, unverified label Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage New bug, unverified
Projects
None yet
Development

No branches or pull requests

1 participant