BUG,CI: Fix strdup declaration on Cygwin and add Cygwin CI. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Required to get definitions assumed to be there.
|
Note: Compiler crashes when linking one of the tests. Not sure how to debug that. |
|
Three layers of headers in, pybind11.h does include Python.h, after only a single file with a comment explaining in what circumstances it breaks things. I think the other file is only relevant if debugging on Windows. The crash on Cygwin is odd, but I have no idea what to do about that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Attempts to fix pybind#4999
Suggested changelog entry: