Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional tests for Casadi modes #4027

Open
BradyPlanden opened this issue Apr 20, 2024 · 0 comments · May be fixed by #4028
Open

Additional tests for Casadi modes #4027

BradyPlanden opened this issue Apr 20, 2024 · 0 comments · May be fixed by #4028
Labels

Comments

@BradyPlanden
Copy link
Member

Description

At the moment, I believe the Casadi solver modes are tested on a toy model:

def test_model_solver(self):
, but not formally across the particle models.

This issue is to add additional tests on an SPM or equivalent with assert for ensuring the results for each solver mode.

Motivation

As we are moving towards the "safe with events" mode in PyBOP, it would be ideal to have the mode tested for across the pybamm models.

Possible Implementation

No response

Additional context

No response

@BradyPlanden BradyPlanden linked a pull request Apr 20, 2024 that will close this issue
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant