Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: pybamm.Simulation.set_parameters, pybamm.Simulation.set_up_and_parameterise_experiment and pybamm.Simulation.set_up_and_parameterise_model_for_experiment should be private (i.e. begin with underscore _) and not documented #3973

Closed
hectormara opened this issue Apr 9, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@hectormara
Copy link

PyBaMM Version

23.9

Python Version

3.11.7

Describe the bug

It is a small issue for the training workshop on the 17th of April

Steps to Reproduce

Read the scripts of Simulation

Relevant log output

No response

@hectormara hectormara added the bug Something isn't working label Apr 9, 2024
@agriyakhetarpal
Copy link
Member

Hi, @hectormara – this issue is currently open in #3751 and there is a PR being worked on for it. Could you please pick a different item off the list and open a new issue (or better, edit the title and description for this one)?

@kratman
Copy link
Contributor

kratman commented Apr 9, 2024

Closing since it is a duplicate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants