Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass solver or tol to all eSOH classes/methods #3930

Open
rtimms opened this issue Mar 26, 2024 · 1 comment
Open

Pass solver or tol to all eSOH classes/methods #3930

rtimms opened this issue Mar 26, 2024 · 1 comment
Labels

Comments

@rtimms
Copy link
Contributor

rtimms commented Mar 26, 2024

Sometimes the eSOH models/methods fail to converge within the default tolerance (1e-6). It would be good to be able to pass a solver object to the classes/methods to give the user more control. Currently, you can only pass a tolerance to get_initial_stoichiometries. It would be good to make the API uniform across all methods and probably try to clean the code up a bit at the same time - it's extremely convoluted.

@abillscmu
Copy link
Contributor

abillscmu commented Mar 27, 2024

Yeah I just wanted the ticket as more of a reminder to myself to go back and check for them

from @kratman reminder to check for if known_value == with no else (see #3921)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants