Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename parameters from "electrode" to "particle" #3770

Closed
julian-evers opened this issue Jan 26, 2024 · 1 comment
Closed

Rename parameters from "electrode" to "particle" #3770

julian-evers opened this issue Jan 26, 2024 · 1 comment

Comments

@julian-evers
Copy link
Contributor

As "positive electrode diffusivity" is currently renamed to "positive particle diffusivity" it might be a good time to rename other parameters similarly as non-breaking changes with deprecation warnings, though that might not be perfect for film-type electrodes. How do you think about below parameter names?

  • Initial concentration in positive particle [mol.m-3]
  • Maximum concentration in positive particle [mol.m-3]
  • Positive electrode Bruggeman coefficient (particle)
  • Positive particle charge transfer coefficient
  • Positive particle exchange-current density [A.m-2]
@valentinsulzer
Copy link
Member

We're reviewing how parameters are defined as part of #3909 . Let's discuss there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants