Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dB_transform ignores existing metadata #198

Open
dnerini opened this issue Dec 30, 2020 · 0 comments · Fixed by #223
Open

dB_transform ignores existing metadata #198

dnerini opened this issue Dec 30, 2020 · 0 comments · Fixed by #223
Assignees
Labels
discussion an open discussion for whole community

Comments

@dnerini
Copy link
Member

dnerini commented Dec 30, 2020

Original report

(by Valentina Gregori)

I also noticed another small issue (already in the previous version of pysteps). When I do a conversion to reflectivity using the function conversion.to_reflectivity(R, metadata) the output value of metadata['zerovalue'] is not as expected. I think this happens because in the transformation.dB_transform function, which is called by conversion.to_reflectivity, the code that checks if "zerovalue" is a key of metadata is missing:

if zerovalue is None:
    zerovalue = metadata.get("zerovalue", threshold-5)

for now, it seems that the "zerovalue" is only replaced by "threshold-5". Do you think it makes sense?
Thanks in advance!

@dnerini dnerini added the bug Something isn't working label Dec 30, 2020
@dnerini dnerini self-assigned this Dec 30, 2020
@dnerini dnerini added this to the release v1.4.1 milestone Jan 2, 2021
@dnerini dnerini added discussion an open discussion for whole community and removed bug Something isn't working labels Jan 15, 2021
@dnerini dnerini removed this from the release v1.4.1 milestone Jan 15, 2021
@dnerini dnerini linked a pull request Oct 12, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion an open discussion for whole community
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant