Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use logging instead of print #140

Open
fox91 opened this issue Feb 20, 2020 · 4 comments
Open

Use logging instead of print #140

fox91 opened this issue Feb 20, 2020 · 4 comments
Labels
discussion an open discussion for whole community enhancement New feature or request
Projects

Comments

@fox91
Copy link

fox91 commented Feb 20, 2020

Are you interested in migrating all log messages from the simple print to the more standard logging module?

Given the high number of logs that the outputs are written I think it may be useful to many to have a common method to manage them.

Let me know if you want my contribution to introduce the use of the logging module in this fantastic framework!

@dnerini dnerini added discussion an open discussion for whole community enhancement New feature or request labels Feb 20, 2020
@dnerini
Copy link
Member

dnerini commented Feb 20, 2020

Hi Andrea, welcome to pysteps!

This is an excellent proposition and certainly very appropriated considering the stage at which the package is now.
I'm in favor of such development, let's see if anyone else has a strong opinion about that. Perhaps @pulkkins, @aperezhortal or @cvelascof ?

I'm also happy to contribute, in case we decide to take this idea forward. Perhaps it would be interesting if you, @fox91, could prepare a brief example or proposition of how we could use logging within pysteps? This way, we could better assess the work needed for a full implementation.

@aperezhortal
Copy link
Member

aperezhortal commented Feb 20, 2020

Hi Andrea, I really like the idea! With the logging module with can have fine control of the logging output. Perhaps we can start the logging implementation one module at a time.

@fox91
Copy link
Author

fox91 commented Feb 20, 2020

Hi Daniele and Andres,
I can make a PR in the next days implementing the logging module in the pysteps.nowcasts module that I'm currently using.
After that we can implement it in the others and, when all the modules are updated, we can merge the PR everything at once.

@dnerini
Copy link
Member

dnerini commented Feb 20, 2020

Sounds excellent!

@ladc ladc mentioned this issue Jul 23, 2021
@dnerini dnerini added this to To do in pysteps-v2 via automation Jul 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion an open discussion for whole community enhancement New feature or request
Projects
Development

Successfully merging a pull request may close this issue.

3 participants