Enabled chai provider with proxy user if SSO enabled #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…word Bug fix/not using proxy for change password
|
I would test to make sure you can’t sign in as anyone via sso bypass pages. This seems like it creates a loophole in the authentication. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some modules like the Change Password or Update profile modules do not support SSO authentication. This because
In case a proxy user has been defined, this one can be used to generate the chai provider for SSO users. The pull request check if the proxy user is defined and, if so, create a chai provider based on the proxy user in the authenticateUserWithoutPassword method.
Resolve #619