Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tftp resources blocks #692

Open
purpleidea opened this issue Oct 17, 2022 · 1 comment
Open

tftp resources blocks #692

purpleidea opened this issue Oct 17, 2022 · 1 comment

Comments

@purpleidea
Copy link
Owner

See here: pin/tftp#41

@vpaprots commented:

If somebody else stumbles upon this, as I did.. mine hung on a large file (~100mb). s.SetBlockSize(65456) appears to have fixed it. (This might be 'per-spec', I didn't dig all that much.. I think dnsmasq-tftp has a similar issue with block size..)

@purpleidea
Copy link
Owner Author

https://github.com/pin/tftp/blob/90a06610acdd87d99706c4ea8328b60a04d9a8e7/server.go#L144

As an aside, we should test the latest version since there is some new cancellation code in Shutdown().

But if a client was reading a super huge file, we'd want them to get disconnected perhaps... That should be something we should check to see if it occurs. Otherwise a malicious client could slow read for a long time to block us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant