test: Fix commit testing #646
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evrardjp
force-pushed
the
fix-commit-message-testing
branch
12 times, most recently
from
bbf42a8
to
331d10e
Compare
|
Removed the BREAK stuff patch, which is failing (on purpose). |
Currently, the testing of commits is in CI, and is CI dependent. This is a problem if we switch to a new CI, or if someone wants to test locally. This fixes it by making sure the test/test-commit-message can be triggered locally, and finds the new commits. As a side benefit, test/test-commit-message easier to understand: It compares the HEAD of the branch until reaching a common ancestor in origin, listing all the SHAs, and send those to the testing functions.
evrardjp
force-pushed
the
fix-commit-message-testing
branch
from
331d10e
to
bd85bf6
Compare
|
Updated: Was broken because I was using spaces. Replaced spaces with tabs. Yes, I had to sell my soul for this patch to land. 😆 |
purpleidea
force-pushed
the
master
branch
4 times, most recently
from
2319f4f
to
04f5ba6
Compare
purpleidea
force-pushed
the
master
branch
4 times, most recently
from
fe2313c
to
271a94e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the testing of commits is in CI, and is CI
dependent.
This is a problem if we switch to a new CI, or if someone
wants to test locally.
This fixes it by making sure the test/test-commit-message
can be triggered locally, and finds the new commits.
As a side benefit, test/test-commit-message easier to understand:
It compares the HEAD of the branch until reaching a common
ancestor in origin, listing all the SHAs, and send those to
the testing functions.
Closes: #643