Move event to default configuration #3381
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dentarg
reviewed
May 14, 2024
lib/puma/cli.rb
Outdated
| def initialize(argv, log_writer = LogWriter.stdio, events = Events.new) | ||
| def initialize(argv, log_writer = LogWriter.stdio) |
There was a problem hiding this comment.
Not sure we can change the signature of Puma::CLI, it is probably considered public API?
There was a problem hiding this comment.
Yeah, #2798 changed the signature and it caused breakage
There was a problem hiding this comment.
Ok, I am not sure on this if we can change the public API Here. How you want me to take this forward?
The other around is just introduce a Puma:Events in control_cli.rb and that should also work. instead of introducing it at default config level.
Or maybe just introduce a default events in Configuration.rb without changing/cleaning up cli. (Gone with this as of now)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3356
Your checklist for this pull request
[ci skip]to the title of the PR.#issue" to the PR description or my commit messages.