Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pulp is running gunicorn's cli parser on startup. #5217

Open
gerrod3 opened this issue Apr 2, 2024 · 0 comments
Open

Pulp is running gunicorn's cli parser on startup. #5217

gerrod3 opened this issue Apr 2, 2024 · 0 comments
Labels

Comments

@gerrod3
Copy link
Contributor

gerrod3 commented Apr 2, 2024

Version
pulp>=3.44,<3.51

Describe the bug
From this change: 55043f3, Pulp began loading the gunicorn defaults when starting. Part of gunicorn default loading is parsing the arguments passed in: https://github.com/benoitc/gunicorn/blob/master/gunicorn/app/base.py#L158. This happens to work since we mostly duplicate every option for our entrypoints. However our --limit-request-field-size option does not match what gunicorn uses: --limit-request-field_size (https://docs.gunicorn.org/en/stable/settings.html#limit-request-field-size). If you specify this option you will get an error when gunicorn parses the cli args.

We shouldn't let gunicorn parse our cli args.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants