Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the is_modular flag from the Package model #3524

Open
dralley opened this issue May 7, 2024 · 0 comments · May be fixed by #3525
Open

Remove the is_modular flag from the Package model #3524

dralley opened this issue May 7, 2024 · 0 comments · May be fixed by #3525
Assignees
Labels

Comments

@dralley
Copy link
Contributor

dralley commented May 7, 2024

The only place it's currently used is in depsolving and retention policy handling. IIRC, it exists mostly because it was done that way in Pulp 2 more than any other reason - but this design is problematic.

  1. The module upload workflow (as opposed to syncing) requires that the packages themselves already be uploaded into Pulp beforehand - but there is no way to upload a package such that the is_modular flag will be set. Therefore this is not a reliable way to know whether a package is "modular" or not.

  2. Additionally we've had some problems with packages that have been synced as both part-of-a-module and not-part-of-a-module.

So, we need to ditch that field, and ensure that any mechanisms that need to know whether or not a package is modular can do so without that field being present.

@dralley dralley self-assigned this May 7, 2024
dralley added a commit to dralley/pulp_rpm that referenced this issue May 7, 2024
dralley added a commit to dralley/pulp_rpm that referenced this issue May 7, 2024
@dralley dralley linked a pull request May 7, 2024 that will close this issue
dralley added a commit to dralley/pulp_rpm that referenced this issue May 9, 2024
dralley added a commit to dralley/pulp_rpm that referenced this issue May 21, 2024
dralley added a commit to dralley/pulp_rpm that referenced this issue May 21, 2024
dralley added a commit to dralley/pulp_rpm that referenced this issue May 21, 2024
dralley added a commit to dralley/pulp_rpm that referenced this issue May 21, 2024
dralley added a commit to dralley/pulp_rpm that referenced this issue May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Needs review
Development

Successfully merging a pull request may close this issue.

1 participant