Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make deploy should not require go #773

Open
kurokobo opened this issue Nov 14, 2022 · 0 comments
Open

make deploy should not require go #773

kurokobo opened this issue Nov 14, 2022 · 0 comments
Labels
Documentation Improvements or additions to documentation Issue

Comments

@kurokobo
Copy link
Contributor

Version
N/A

Describe the bug
Invoking make deploy as guided in Getting Started for Pulp Operator requires go binary because deploy refers manifests and manifests requires controller-gen which uses go.

It's ok for devs since current operator is written in Go, but for users, it's like an unnecessary dependency. I think this dependency should be removed, or Getting Started should be updated that the command requires go (or provide alternative handy way without make deploy to deploy Operaotr).

To Reproduce

  1. Clone this repository
  2. Invoke make deploy

Expected behavior
Pulp Operator can be deployed without go binary.
@mikedep333 mikedep333 added Documentation Improvements or additions to documentation and removed Triage-Needed labels Nov 29, 2022
git-hyagi added a commit to git-hyagi/pulp-operator that referenced this issue Feb 8, 2023
@git-hyagi
Add target to install golang in Makefile
dfd8629 
There are tasks in ci-operator that are failing because golang is
not installed. This commit will verify if golang is found in the
common install path and install it if necessary.
ref: pulp#773
[noissue]
git-hyagi added a commit to git-hyagi/pulp-operator that referenced this issue Feb 8, 2023
@git-hyagi
Add target to install golang in Makefile
196cbfd 
There are tasks in ci-operator that are failing because golang is
not installed. This commit will verify if golang is found in the
common install path and install it if necessary.
ref: pulp#773
[noissue]
git-hyagi added a commit to git-hyagi/pulp-operator that referenced this issue Feb 8, 2023
@git-hyagi
Add target to install golang in Makefile
afd065b 
There are tasks in ci-operator that are failing because golang is
not installed. This commit will verify if golang is found in the
common install path and install it if necessary.
ref: pulp#773
[noissue]
@git-hyagi git-hyagi mentioned this issue Feb 8, 2023
Merged
openshift-merge-robot pushed a commit that referenced this issue Feb 8, 2023
@git-hyagi @openshift-merge-robot
Add target to install golang in Makefile
5df6b38 
There are tasks in ci-operator that are failing because golang is
not installed. This commit will verify if golang is found in the
common install path and install it if necessary.
ref: #773
[noissue]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Documentation Improvements or additions to documentation Issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mikedep333 @kurokobo