Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/Fix release script and csv #1202

Open
git-hyagi opened this issue Jan 18, 2024 · 0 comments
Open

Update/Fix release script and csv #1202

git-hyagi opened this issue Jan 18, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@git-hyagi
Copy link
Collaborator

Describe the bug
Releasing a new version of the operator using the release.sh script will fail community-operators and community-operators-prod pipelines because of:

  • missing metadata.annotations.support field (new required field)
  • containerImage is not used by any container in the csv
  • bundle replace version not found

and also some warnings:

Value : (pulp-operator.v1.0.0-beta.4) csv.Spec.minKubeVersion is not informed. It is recommended you provide this information. Otherwise, it would mean that your operator project can be distributed and installed in any cluster version available, which is not necessarily the case for all projects.
Value pulp-operator.v1.0.0-beta.4: this bundle is using APIs which were deprecated and removed in v1.25. More info: https://kubernetes.io/docs/reference/using-api/deprecation-guide/#v1-25. Migrate the API(s) for cronjobs: (["ClusterServiceVersion.Spec.InstallStrategy.StrategySpec.Permissions[0].Rules[4]"]),poddisruptionbudgets: (["ClusterServiceVersion.Spec.InstallStrategy.StrategySpec.Permissions[0].Rules[10]"]),

Expected behavior
We should update the release.sh script to avoid these errors and/or manual intervention by:

  • adding the metadata.annotations.support: Community field in the pulp-operator.clusterserviceversion.yaml file
  • fixing the missing v in:
    sed -i "s#containerImage: quay.io/pulp/pulp-operator:devel#containerImage: quay.io/pulp/pulp-operator:${PULP_OPERATOR_RELEASE_VERSION}#g" $CSV_FILE
    echo " replaces: pulp-operator.${PULP_OPERATOR_REPLACE_VERSION}" >> $CSV_FILE
    • it should be:
  sed -i "s#containerImage: quay.io/pulp/pulp-operator:devel#containerImage: quay.io/pulp/pulp-operator:v${PULP_OPERATOR_RELEASE_VERSION}#g" $CSV_FILE
  echo "  replaces: pulp-operator.v${PULP_OPERATOR_REPLACE_VERSION}" >> $CSV_FILE

Additional context
Maybe the warning should be handled through a separate issue. (Keeping it here for now)

@git-hyagi git-hyagi added the bug Something isn't working label Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant