Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pulp-cli 0.25 compatibility and bump version #115

Merged
merged 1 commit into from May 6, 2024

Conversation

quba42
Copy link
Collaborator

@quba42 quba42 commented Apr 26, 2024

No description provided.

@quba42
Copy link
Collaborator Author

quba42 commented Apr 26, 2024

I will undraft this once I have studied the Pulp CLI 0.25.0 deprecations and performed some basic tests.

@mdellweg
Copy link
Member

mdellweg commented Apr 26, 2024

This line should fail:
https://github.com/pulp/pulp-cli-deb/blob/main/pulp-glue-deb/pulp_glue/deb/context.py#L11
How comes it doesn't?

edit:
The pip cache should be considered outdated at this time.
https://github.com/pulp/pulp-cli-deb/blob/main/.github/workflows/test.yml#L39

@mdellweg
Copy link
Member

You need to bump the pulp-glue requirement too too pick up the new version.

@quba42 quba42 linked an issue Apr 26, 2024 that may be closed by this pull request
@quba42 quba42 force-pushed the bump_cli_version_range branch 3 times, most recently from 0bc10b3 to 5d562c2 Compare May 6, 2024 14:00
@quba42 quba42 changed the title Declare pulp-cli 0.25 compatibility Fix pulp-cli 0.25 compatibility and bump version May 6, 2024
pyproject.toml Outdated Show resolved Hide resolved
@quba42 quba42 marked this pull request as ready for review May 6, 2024 15:38
@quba42 quba42 merged commit 85d8685 into pulp:main May 6, 2024
13 of 14 checks passed
@quba42 quba42 deleted the bump_cli_version_range branch May 6, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix compatibility against Pulp CLI 0.25
2 participants