Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encoding error at holdings endpoint #1041

Closed
hackartisan opened this issue Feb 3, 2021 · 1 comment
Closed

Encoding error at holdings endpoint #1041

hackartisan opened this issue Feb 3, 2021 · 1 comment
Assignees
@hackartisan
Labels
alma-implementation

Comments

@hackartisan
Copy link
Member

hackartisan commented Feb 3, 2021 •
edited

https://app.honeybadger.io/projects/54497/faults/74869729/c27c2aae-6572-11eb-91cc-3d3c1a6d177d#notice-summary

Accesing this same mmsid at endpoints using alma-rb don't have the same issue. It would be nice to push holdings up to that gem. For now I'll likely just force the encoding.
@hackartisan hackartisan self-assigned this Feb 3, 2021
@hackartisan
Copy link
Member Author

hackartisan commented Feb 3, 2021 •
edited

This is the bug:

I can observe the records coming in from Faraday as ascii-8bit but I can't get a fixture to work for a test. Rails is too good at preferring utf-8 at every step along the way.

@hackartisan hackartisan mentioned this issue Feb 3, 2021
Merged
hackartisan added a commit that referenced this issue Feb 4, 2021
@hackartisan
Ensure we encode alma responses as utf-8
d22ab4e 
fixes #1041
hackartisan added a commit that referenced this issue Feb 8, 2021
@hackartisan
Ensure we encode alma responses as utf-8
e411aa8 
fixes #1041
hackartisan added a commit that referenced this issue Feb 22, 2021
@hackartisan
Ensure we encode alma responses as utf-8
637c7bf 
fixes #1041
hackartisan added a commit that referenced this issue Mar 15, 2021
@hackartisan
Ensure we encode alma responses as utf-8
587816a 
fixes #1041
hackartisan added a commit that referenced this issue Mar 22, 2021
@hackartisan
Ensure we encode alma responses as utf-8
460bd6e 
fixes #1041
hackartisan added a commit that referenced this issue Mar 29, 2021
@hackartisan
Ensure we encode alma responses as utf-8
1bba5a5 
fixes #1041
hackartisan added a commit that referenced this issue Apr 12, 2021
@hackartisan
Ensure we encode alma responses as utf-8
9ce1ae8 
fixes #1041
hackartisan added a commit that referenced this issue May 3, 2021
@hackartisan
Ensure we encode alma responses as utf-8
9cdff84 
fixes #1041
hackartisan added a commit that referenced this issue Jun 7, 2021
@hackartisan
Ensure we encode alma responses as utf-8
fbca941 
fixes #1041
hackartisan added a commit that referenced this issue Jul 23, 2021
@hackartisan
Ensure we encode alma responses as utf-8
e52c92c 
fixes #1041
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hackartisan hackartisan

Labels
alma-implementation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hackartisan