Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Quilt #143

Open
jschenke488 opened this issue Apr 26, 2022 · 6 comments
Open

Add Quilt #143

jschenke488 opened this issue Apr 26, 2022 · 6 comments

Comments

@jschenke488
Copy link

Add Quilt template. Should be exactly the same as Fabric except https://github.com/PufferPanel/PufferPanel/blob/master/operations/fabricdl/fabricdl.go#L12 would use https://meta.quiltmc.org/v3/versions/installer and the install command is slightly different.

@CristianEduardMihai
Copy link
Contributor

Unfortunately, I don't have any experience with Quilt, but you can try using the built-in template editor to make one.
It's pretty easy.

@thecmdradama
Copy link
Contributor

Wouldn't be as easy to just create a template for quilt. One option is to allow the FabricMetadataUrl string in fabricdl.go to be configured in the template.. Probably no need to create a new operation for it.

@rickiewars
Copy link
Contributor

The quilt equivalent to the FabricMetadataUrl would be: https://meta.quiltmc.org/v3/versions/installer
Also fabric-installer.jar would need to be changed to quilt-installer.jar

I would also want a template for quilt because quilt seems to take over fabric. Some mods seem to move from fabric to quilt and quilt supports all fabric mods.

@CristianEduardMihai
Copy link
Contributor

The quilt equivalent to the FabricMetadataUrl would be: https://meta.quiltmc.org/v3/versions/installer Also fabric-installer.jar would need to be changed to quilt-installer.jar

I would also want a template for quilt because quilt seems to take over fabric. Some mods seem to move from fabric to quilt and quilt supports all fabric mods.

Hi! Quilt seems very interesting. I'll try to help you out by making a template when I have some free time. Until then, if you already possess the knowledge required to make the server, try making a template on your own using the built-in editor and share it with us via a PR :). It's not that hard and you can ask here for help.

@rickiewars
Copy link
Contributor

rickiewars commented Dec 7, 2022

I've gone ahead and tried to implement my own version of the quiltdl function.
Unfortunately, I haven't been able to test this because I keep getting 404 errors. (Normally, I run PufferPanel inside Docker).

If someone wants to test this code, the fork can be found on: https://github.com/rickiewars/PufferPanel
Tomorrow, I'm going to try again to test this and maybe I'm able to handin two pull-requests, one for the download function and one for the template.

I'm not a Go programmer (I normally write my code in C++) so I have no clue if this function actually works, I've just adapted most of what I've found in the FabricDl function.

@rickiewars
Copy link
Contributor

Instead of trying to getting my build to work to test my quiltdl.go file, I've decided to take the advice of @CristianEduardMihai and take the easy way by creating just a template file.
I've got something working which I'm creating a pull-request for now.
If someone wants to improve on it by creating a quiltdl function, my efforts can be found at https://github.com/rickiewars/PufferPanel (I've not been able to test it so don't know if it works other than "it compiles")

rickiewars added a commit to rickiewars/templates that referenced this issue Jan 14, 2023
New pull request to push to V2.6.
Original pull request: pufferpanel#191 
Solves: pufferpanel#143
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants